fix: only load Version from properties once #1886
Conversation
|
SonarCloud Quality Gate failed. |
| @@ -53,7 +53,7 @@ public BaseConfigurationService(Version version, Cloner cloner) { | |||
| } | |||
|
|
|||
| public BaseConfigurationService() { | |||
There was a problem hiding this comment.
Actually I'm not sure about this, really try to avoid static stuff.
Also the whole ConfigurationServiceProvider should go away soon (hopefully)
There was a problem hiding this comment.
Yes, but this is actually a fix until the provider goes away. There is absolutely no reason for the version to be anything but static in any case since it never needs to be reloaded and should not change once the SDK is up.
There was a problem hiding this comment.
So it does not change neither in the current case, since the service is only can be initialized once. (What I achieve is to have static variables, because of the issue we having)
There was a problem hiding this comment.
It's not true, currently, the properties are reloaded anytime you reset the ConfigurationServiceProvider.
There was a problem hiding this comment.
But the reset is only mean for testing purposes.
There was a problem hiding this comment.
No, it's used in QOSDK because the static nature of the provider is causing issues when the app restarts in dev mode. So yes, the static provider should be removed because it's causing more issues than helping but in the meantime, I'd like this fix (possibly for a 4.3.2 release soon with Fabric8 6.6.0 as well).
No description provided.